Skip to content

Conversation

@atacann
Copy link
Contributor

@atacann atacann commented Nov 18, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 18, 2025 16:09
Copilot finished reviewing on behalf of atacann November 18, 2025 16:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling in the aggregator's compatibility checking system by introducing better error granularity and concurrent execution. The main changes include:

  • Renamed join_all_combine_errors to try_join_all_combine_errors for clarity
  • Added new join_all_partition_results utility to allow partial successes while collecting errors
  • Introduced CompatibilityCheckScope enum to replace boolean flags for better API design
  • Refactored check_compatibility_with_actors to run operator and verifier compatibility checks concurrently and provide separate error messages for each group

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
core/src/utils.rs Renamed join_all_combine_errors to try_join_all_combine_errors; added new join_all_partition_results function for partitioning successes and failures
core/src/aggregator.rs Added CompatibilityCheckScope enum; refactored check_compatibility_with_actors to use the new enum and run checks concurrently with improved error messages
core/src/rpc/aggregator.rs Updated all function calls to use renamed try_join_all_combine_errors and new CompatibilityCheckScope enum values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@atacann atacann marked this pull request as ready for review November 20, 2025 16:27
@atacann atacann requested a review from a team as a code owner November 20, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants