-
Notifications
You must be signed in to change notification settings - Fork 105
ENT-11481: Redirection from HTTP to HTTPS responsibility moved from Apache to PHP #3049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nickanderson can you please help with cfe_enterprise_disable_http_redirect_to_https class? I see we mention it in some places. remove mentions? or keep as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is more to this that's needed. I'll try to get to it today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor changes needed. I think this covers it.
MPF.md
Outdated
|
||
* Added in CFEngine 3.6.0 | ||
* Class renamed from `cfe_cfengine_enterprise_enable_plain_http` to `cfe_enterprise_disable_http_redirect_to_https` in CFEngine 3.23.0, 3.21.3 | ||
* Redirection responsibility moved from Apache to PHP in CFEngine 3.27.0, 3.24.3, 3.21.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned back-porting so I filled out all the upcoming releases here.
Feel free to squash all my commits into yours |
8d37e12
to
59c10ca
Compare
@nickanderson I fixed directory perms 59c10ca please check if I did it in a proper way. (tested and it works) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aleksandrychev what you have is OK, would work, but I suggested to swap the order to make sure the directory get's created with the correct permissions first.
And I wonder if we should denote this flags directory as "configuration" files for packaging (thinking things like rpm -V
)
f8ef5af
to
03fab32
Compare
03fab32
to
312dc5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@craigcomstock @vpodzime any opinion if we should alter packaging to identify this flags directory as contining "Configuration files" ?
Do we even "track" the |
ChangeLog: Title Ticket: ENT-11481 Signed-off-by: Ihor Aleksandrychiev <[email protected]>
312dc5c
to
1f05749
Compare
No. We don't mention |
@aleksandrychev I'll let you merge this if you think it is ready. |
No description provided.