CFE-4582: Added fsattrs bodies for the immutable bit #3037
+69
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickanderson
commented
Aug 28, 2025
nickanderson
force-pushed
the
CFE-4582/master
branch
from
1265e21 to
991e019
Compare
nickanderson
commented
Aug 28, 2025
nickanderson
force-pushed
the
CFE-4582/master
branch
from
3bb602e to
1d08559
Compare
| immutable => "$(CF_BOOL)"; # The i attribute supported by chattr | ||
| } | ||
|
|
||
| body fsattrs is_immutable |
There was a problem hiding this comment.
seems like this should rather be
body fsattrs is_immutable
{
inherit_from => immutable("true");
}
To avoid a bunch of repetition of examples, etc here.
There was a problem hiding this comment.
yeah, I had considered that but instead preferred for the others to be more stand alone.
| immutable => "true"; # The i attribute supported by chattr | ||
| } | ||
|
|
||
| body fsattrs is_not_immutable |
There was a problem hiding this comment.
maybe
body fsattrs is_not_immutable
{
inherit_from => immutable("false");
}
This introduces a new fsattrs immutable body for use with the files promise type. When applied, it ensures that the promised file has the immutable (i) attribute set. The agent will transparently manage the attribute, removing it before any necessary file modifications and restoring it afterwards. To simplify usage, is_immutable and is_not_immutable bodies were introduced as direct aliases for the parameterized immutable with "true" and "false" arguments, respectively. Ticket: CFE-4582 Changelog: Title
nickanderson
force-pushed
the
CFE-4582/master
branch
from
4ff774c to
020c4d2
Compare
nickanderson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new fsattrs immutable body for use with the files promise
type. When applied, it ensures that the promised file has the immutable (i)
attribute set. The agent will transparently manage the attribute, removing it
before any necessary file modifications and restoring it afterwards.
Ticket: CFE-4582
Changelog: Title