Skip to content

Conversation

johannes-wolf
Copy link
Member

Fixes #76

@johannes-wolf johannes-wolf added the 👿 bug Something isn't working label Oct 31, 2024
@jamesrswift
Copy link
Collaborator

Tested this branch on what I was doing that highlighted the issue and it works now :)

@jamesrswift jamesrswift self-requested a review October 31, 2024 22:03
@jamesrswift
Copy link
Collaborator

When axes are swapped, there's an issue with scaling it seems

#test-case({
  plot.plot(
    size: (10,6), 
    // y-max: 100,
    {
      plot.add(domain: (20, 30), x=>x, mark: "x", axes:("y", "x"))
    }
  )
})

image

@johannes-wolf
Copy link
Member Author

#test-case({
  plot.plot(
    size: (10,6), 
    // y-max: 100,
    {
      plot.add(domain: (20, 30), x=>x, mark: "x", axes:("y", "x"))
    }
  )
})

Good catch. Fixed.

@johannes-wolf johannes-wolf force-pushed the 76-fix-mark-bounds-check branch from 3f58d38 to 0473652 Compare October 31, 2024 22:52
@johannes-wolf
Copy link
Member Author

This PR introduces new problems, so I suggest closing this in favor of #81 which solves the problem in a better way.

@jamesrswift jamesrswift closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👿 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot marks do not respect axis bounds
2 participants