Better flow-sensitive typing #1114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes out some lower value combinations - ideally we could keep the number of jobs to <= 20, which is the max that GHA will run simultaneously here.
apiology
force-pushed
the
flow_sensitive_typing_2_0
branch
from
0d652a1 to
9aea987
Compare
apiology
force-pushed
the
flow_sensitive_typing_2_0
branch
from
352d8d7 to
82e5bbf
Compare
|
I'm pulling good bits out of apiology#12 - feel free to merge this PR at any point that it's green, I'll probably add more stuff over time while I improve the other PR. |
apiology
force-pushed
the
flow_sensitive_typing_2_0
branch
from
546b70c to
33b7c2d
Compare
apiology
force-pushed
the
flow_sensitive_typing_2_0
branch
from
33b7c2d to
9cba783
Compare
Choose the first one to define the type to assume
apiology
force-pushed
the
flow_sensitive_typing_2_0
branch
from
d3e16c8 to
5d1e9ae
Compare
This would have failed specs except there was already another 'pending' later. Wonder why RSpec doesn't figure this out itself and complain...
apiology
force-pushed
the
flow_sensitive_typing_2_0
branch
from
eb5a85b to
6f5d60a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cases now at least partially handled:
if foo.nil?if foounless foo.nil? || fooif unrelated && foobreak if foo.nil?return foo unless !fooreturn if foo.nil?foo = nilable || not_nilablefoo unless foo.nil? || foofoo if unrelated && foowhile foofoo unless unrelated || repr.nil?Includes for convenience: