Skip to content

Improve gemspec resolution logic #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 121 commits into
base: master
Choose a base branch
from
Open

Improve gemspec resolution logic #1113

wants to merge 121 commits into from

Conversation

apiology
Copy link
Contributor

@apiology apiology commented Oct 9, 2025

Includes:

  • Use RBS stdlib dependencies information to handle situations like YAML, which depends on Psych.
  • Default to using the version of a gem from the workspaces' bundle.
  • Refactors of the external bundle querying code
  • Be careful to avoid relying on Gem::Specification methods for identity / sorting / hashing / etc - the 'bundler' Gem::Specification in particular seems to not have all the bells and whistles in some Ruby configurations.

Depends on and includes:

See apiology#10 for a more useful diff that doesn't include #1067

apiology added 30 commits August 30, 2025 09:06
@apiology
RuboCop todo file stability
6acfa0c 
To avoid merge conflicts and contributors having to deal with
non-intuitive RuboCop todo changes:

* Lock down development versions of RuboCop and plugins so that
  unrelated PRs aren't affected by newly implemented RuboCop rules.
* Exclude rule entirely if more than 5 files violate it today, so that
  PRs are less likely to cause todo file changes unless they are
  specifically targeted at cleanup.
* Clarify guidance on RuboCop todo file in CI error message.
* Fix to hopefully ensure guidance always appears in CI error message.
@apiology
Merge remote-tracking branch 'origin/master' into rubocop_stability
14be6bf
@apiology
Fix merge issue
61260f3
@apiology
Pull in overcommit fix
f623a73
@apiology
Add spec
a8b678b
@apiology
Extract gemspec, bundle and dependency management into its own class
5b6a4af
@apiology
Add @sg-ignore
74e1baf
@apiology
Merge branch 'rubocop_stability' into improve_gemspecs_logic
ef2a81f
@apiology
Update rubocop todo file
947d5b9
@apiology
Add some new specs
c1e4c8d
@apiology
Convince GHA to run on branch of branch
f32bb17
@apiology
Convince GHA to run on branch of branch
b1a736d
@apiology
Convince GHA to run on branch of branch
87cb546
@apiology
Convince GHA to run on branch of branch
99c8b34
@apiology
Convince GHA to run on branch of branch
b9a16c4
@apiology
Mark another new spec as pending
76e37a5
@apiology
Mark another new spec as pending
e08b61b
@apiology
Show missing coverage
33b9cb1
@apiology
Handle some missed coverage areas
33a1857
@apiology
Clean up RSpec/MessageSpies rubocop violations
7c21510
@apiology
Merge branch 'message_spies_linting' into extract_gemspecs_logic_from…
82bdb21 
…_doc_map
@apiology
Fix up allow syntax
5afe71b
@apiology
Merge branch 'message_spies_linting' into extract_gemspecs_logic_from…
2e3e9b7 
…_doc_map
@apiology
Allow solargraph version to be overidden for test purposes
aaa7573 
Useful for:
1. Maintaining a separate pin cache per branch to avoid contamination
   and get more accurate spec results locally
2. Testing solargraph-rails against branches consolidating multiple
   open PRs (e.g., the dated ones at
   https://github.com/apiology/solargraph/pulls)

Includes a direnv implementation for #1
@apiology
Merge branch 'rubocop_stability' into solargraph_force_version
b16594d
@apiology
Merge branch 'rubocop_stability' into message_spies_linting
7f2d490
@apiology
Merge branch 'message_spies_linting' into extract_gemspecs_logic_from…
b7505f7 
…_doc_map
@apiology
Exercise log statements too
c4f9246
@apiology
Merge branch 'solargraph_force_version' into extract_gemspecs_logic_f…
50f6ecf 
…rom_doc_map
@apiology
Better versioning in example
5433479
apiology added 27 commits October 5, 2025 18:57
@apiology
Document method
ac05669
@apiology
Drop untested change
84fb049
@apiology
Fix typo in existing code
4fb2b2c
@apiology
Back out spec
e25702f
@apiology
Add more solargraph-rspec requires
0aefc35
@apiology
Fix syntax
358ff37
@apiology
Use bundle information to resolve gemspecs
ada4c12
@apiology
Merge branch 'extract_gemspecs_logic_from_doc_map' into improve_gemsp…
b2e7252 
…ecs_logic
@apiology
Handle LazySpecification issue
2c7079c
@apiology
Drop @sg-ignore
5a982ad
@apiology
Handle LazySpecification issue
57af0eb
@apiology
Handle LazySpecification issue
e1db9a8
@apiology
Adjust specs
719f441
@apiology
Add space for better future merge
71ac7b5
@apiology
Add space for better future merge
9d7ed97
@apiology
Add more space for future merges
66870f0
@apiology
Simplify code with find_gem, satisfy rubocop
7365c35
@apiology
Merge branch 'reduce_num_of_buid_jobs' into improve_gemspecs_logic
0c751de
@apiology
Don't rely on gemspec being hashable
ba1400c
@apiology
Remove unused methods
fa96091
@apiology
Add back stdlib_dependencies() for use in future merge
7d8b5a3
@apiology
Add back stdlib_dependencies() for use in future merge
149962d
@apiology
Remove temporary changes
5ea669e
@apiology
Remove temporary changes
6421637
@apiology
Remove temporary changes
d45652b
@apiology
Remove temporary changes
f3ca90c
@apiology
Remove temporary changes
d6aacef
@apiology apiology marked this pull request as ready for review October 9, 2025 11:32
@apiology apiology mentioned this pull request Oct 9, 2025
Draft
8 tasks
@apiology apiology changed the title Improve gemspecs logic Improve gemspec resolution logic Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@apiology