Skip to content

Keep workspace directories as absolute paths #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Keep workspace directories as absolute paths #1076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
930d3c6
Keep workspace directories as absolute paths
apiology Sep 11, 2025
2c231ff
Merge branch 'master' into keep_workspaces_as_absolute_paths
apiology Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/solargraph/workspace.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,17 @@ class Workspace
attr_reader :gemnames
alias source_gems gemnames

# @param directory [String]
# @param directory [String] TODO: Remove '' and '*' special cases
# @param config [Config, nil]
# @param server [Hash]
def initialize directory = '', config = nil, server = {}
@directory = directory
raise ArgumentError, 'directory must be a String' unless directory.is_a?(String)

@directory = if ['*', ''].include?(directory)
directory
else
File.absolute_path(directory)
end
@config = config
@server = server
load_sources
Expand Down
3 changes: 2 additions & 1 deletion spec/workspace_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,8 @@

it "uses configured require paths" do
workspace = Solargraph::Workspace.new('spec/fixtures/workspace')
expect(workspace.require_paths).to eq(['spec/fixtures/workspace/lib', 'spec/fixtures/workspace/ext'])
expect(workspace.require_paths).to eq([File.absolute_path('spec/fixtures/workspace/lib'),
File.absolute_path('spec/fixtures/workspace/ext')])
end

it 'ignores gemspecs in excluded directories' do
Expand Down
Loading