-
Notifications
You must be signed in to change notification settings - Fork 227
[VM2] Account Contract support #5316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
darthsiroftardis
merged 16 commits into
casper-network:feat-2.1
from
darthsiroftardis:ac-support
Sep 29, 2025
Merged
[VM2] Account Contract support #5316
darthsiroftardis
merged 16 commits into
casper-network:feat-2.1
from
darthsiroftardis:ac-support
Sep 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-support # Conflicts: # executor/wasm_host/src/host.rs
zajko
reviewed
Sep 18, 2025
zajko
reviewed
Sep 18, 2025
.. | ||
} => Key::SmartContract(*smart_contract_addr), | ||
} => { | ||
if initial_tracking_copy.enable_addressable_entity() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be named addressable_entity_enabled
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ummm I've kept it mirrored to the field name in the chainspec to avoid confusion
zajko
reviewed
Sep 18, 2025
zajko
reviewed
Sep 18, 2025
mpapierski
reviewed
Sep 25, 2025
mpapierski
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR that adds A/C support to VM2, currently the upgrade logic for VM2 contracts needs to be reworked, but I will continue adding commits to this PR