Skip to content

[BUGFIX] SIG_ALL check returns true for other sigflags #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2025

Conversation

lollerfirst
Copy link
Collaborator

@lollerfirst lollerfirst commented Jun 23, 2025

Return true in a SIG_ALL check if no inputs contain SIG_ALL sigflags.
This prevents an early P2PK check in melt from wrongfully rejecting P2PK locked secrets that only have SIG_INPUTS sigflags.

@lollerfirst lollerfirst marked this pull request as draft July 2, 2025 15:04
@lollerfirst lollerfirst changed the title [BUGFIX] Remove anticipated SIG_ALL check [BUGFIX] SIG_ALL check returns true for other sigflags Jul 7, 2025
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.85%. Comparing base (3e32dc4) to head (12604be).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
+ Coverage   55.36%   60.85%   +5.48%     
==========================================
  Files          84       89       +5     
  Lines        9479    10529    +1050     
==========================================
+ Hits         5248     6407    +1159     
+ Misses       4231     4122     -109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lollerfirst lollerfirst marked this pull request as ready for review July 8, 2025 06:51
Copy link
Collaborator

@callebtc callebtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@callebtc callebtc merged commit 92bf631 into cashubtc:main Aug 5, 2025
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants