Skip to content

Conversation

hirzamitz
Copy link
Collaborator

Description

Change thread_timestamp to thread_ts for threaded messages to work. relevant thread

Testing Strategy

Tested changes locally

Checklist

  • I have reviewed this PR with relevant experts and/or impacted teams.
  • I have added tests to have confidence my changes work as expected.
  • I have a rollout plan that minimizes risks and includes monitoring for potential issues.

Thank you for contributing to Misk! 🎉

@hirzamitz hirzamitz requested a review from adrw October 7, 2025 18:52
Copy link
Collaborator

@adrw adrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@hirzamitz hirzamitz merged commit 3ed7273 into master Oct 7, 2025
23 checks passed
@hirzamitz hirzamitz deleted the hp/fix-post-message-request-field-name branch October 7, 2025 20:39
ean5533 added a commit that referenced this pull request Oct 9, 2025
…tric

* origin/master: (22 commits)
  feat: add UrlMatcher to inspect if the Misk Application has a handler for a given URL (#3457)
  Fix edge-case issue with `RetryingTransacter` (#3456)
  Add http_response_header_size to WebConfig (#3453)
  add blpop to redis (#3441)
  fix post message request field name (#3450)
  Support getChatPermalink and threaded responses on slack api (#3447)
  misk-hibernate: use single connection in Vitess shard targeting and improve interface (#3409)
  [bug fix] Fix  `del` operation in FakeRedis.kt (#3449)
  fix: Use TCCL to load classes (#3448)
  adds support for server instructions (#3430)
  misk-testing: create TestFixtureBindingValidator (#3440)
  fix: flaky ExclusiveTimingInterceptorTest (#3446)
  fix: some more flakiness in SubscriptionTest (#3445)
  Bump form-data in /misk-admin/web-actions/development-proxy (#3432)
  fix: flaky SqsJobQueueTest (#3438)
  Misk servlet embeddable to an external servlet containers (#3435)
  feat: reattempt in introducing configurable http/2 control frame limiter with observability (#3422)
  fix: flaky SubscriptionTest (#3437)
  Bump tar-fs from 2.1.1 to 2.1.4 (#3431)
  Bump sha.js from 2.4.11 to 2.4.12 in /misk-admin/web/tabs/database (#3434)
  ...

# Conflicts:
#	misk-mcp/src/main/kotlin/misk/mcp/McpServerModule.kt
#	misk-mcp/src/main/kotlin/misk/mcp/MiskMcpServer.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants