fix: Use TCCL to load classes #3448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the declaring classes CL breaks hot reload as hibernates loads the wrong version of the class.
mpeyper
approved these changes
Oct 6, 2025
wsutina
approved these changes
Oct 6, 2025
jvmakine
approved these changes
Oct 7, 2025
ean5533
added a commit
that referenced
this pull request
Oct 9, 2025
…tric * origin/master: (22 commits) feat: add UrlMatcher to inspect if the Misk Application has a handler for a given URL (#3457) Fix edge-case issue with `RetryingTransacter` (#3456) Add http_response_header_size to WebConfig (#3453) add blpop to redis (#3441) fix post message request field name (#3450) Support getChatPermalink and threaded responses on slack api (#3447) misk-hibernate: use single connection in Vitess shard targeting and improve interface (#3409) [bug fix] Fix `del` operation in FakeRedis.kt (#3449) fix: Use TCCL to load classes (#3448) adds support for server instructions (#3430) misk-testing: create TestFixtureBindingValidator (#3440) fix: flaky ExclusiveTimingInterceptorTest (#3446) fix: some more flakiness in SubscriptionTest (#3445) Bump form-data in /misk-admin/web-actions/development-proxy (#3432) fix: flaky SqsJobQueueTest (#3438) Misk servlet embeddable to an external servlet containers (#3435) feat: reattempt in introducing configurable http/2 control frame limiter with observability (#3422) fix: flaky SubscriptionTest (#3437) Bump tar-fs from 2.1.1 to 2.1.4 (#3431) Bump sha.js from 2.4.11 to 2.4.12 in /misk-admin/web/tabs/database (#3434) ... # Conflicts: # misk-mcp/src/main/kotlin/misk/mcp/McpServerModule.kt # misk-mcp/src/main/kotlin/misk/mcp/MiskMcpServer.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the declaring classes CL breaks hot reload as hibernates loads the wrong version of the class.