Make AwsSqsJobHandlerSubscriptionService public... #3234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to allow usage in the service dependency graph Users may wish to let other Services depend on the AWS JobHandler Subscription service in cases where you want to ensure that SQS job handling has begun before your service has started.
|
I would rather expose an interface that has less implementation details. Happy to pair to unblock this. |
|
Is there anything I can do to help get some movement on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to allow usage in the service dependency graph
Users may wish to let other Services depend on the AWS JobHandler Subscription service in cases where you want to ensure that SQS job handling has begun before your service has started.
As an alternative to making all these classes
open, we could do something like this:And leave the
AwsSqsJobHandlerSubscriptionServiceand all the rest of the classes marked asinternal. Not sure if this would actually work and we'd wanna test this further but from our small injector test it seemed to pass.