Allow the Server to run commands reading from stdin #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many commands such as git-receive-packs do not fit the 'run and get all output' model, as they exchange messages with the remote side via stdin/stdout. This commit should allow any command to run in this otherwise very neat server.
Author
|
It seems that 1 py27 test is failing in Travis but not in my workstation. |
Collaborator
|
@jvrsantacruz would you like to update this PR to be mergable? |
Collaborator
|
@jvrsantacruz can you add test cases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many commands such as git-receive-packs do not fit the
'run and get all output' model that it is offered through the
Python's
Popen.communicate()API.Such commands exchange messages with the remote side via stdin/stdout
alternatively depending on each other's output.
This commit should allow any command to run in this otherwise very neat server.
The rewrite of the process model was necessary in order to be able to use it
as git remote ssh server for testing gi interactions involving key handling, timeouts etc...