-
Notifications
You must be signed in to change notification settings - Fork 108
feat: Add service data filtering support for BLE scanning across all platforms #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emmanuelorobinson
wants to merge
6
commits into
capacitor-community:main
Choose a base branch
from
emmanuelorobinson:cc-impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+316
β17
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4f2d7d6
Merge pull request #2 from capacitor-community/main
emmanuelorobinson cb34b19
...
emmanuelorobinson fddde9e
feat: add service data filtering support for BLE scanning
emmanuelorobinson 26f9066
fix: update TypeScript lib to es2018 and add types for jest and web-bβ¦
emmanuelorobinson b6f0016
feat: document serviceData scan filter and simplify build script
21fc5b3
chore: consolidate service data docs into README, update wording, andβ¦
emmanuelorobinson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the changes to this file mandatory? I can't see any new browser APIs being used in the code you've added...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change to es2018 is required because the code uses Promise.prototype.finally() in src/timeout.ts:8. This method was introduced in ES2018/ES2019 spec.
Without this change, the TypeScript compiler throws
'error TS2550: Property 'finally' does not exist on type 'Promise'.
Do you need to change your target library? Try changing the 'lib' compiler option to 'es2018' or later.'
The finally() method is used in the timeout utility to ensure cleanup (clearing the timeout) happens regardless of whether the promise resolves or rejects. This is the only ES2018 feature being used, but it's essential for the proper cleanup logic.