Skip to content

Conversation

@Schmarvinius
Copy link

I added the bookshop as a sample of how attachments can be implemented.

@Schmarvinius Schmarvinius self-assigned this Nov 10, 2025
@Schmarvinius
Copy link
Author

I want to write the README and think it would be a good idea to put the usage part of the root README into the sample.
The explanation how to use it should still be mentioned and linked.

@lisajulia
Copy link
Contributor

I want to write the README and think it would be a good idea to put the usage part of the root README into the sample. The explanation how to use it should still be mentioned and linked.

Hey @Schmarvinius :)
Thanks, yet we want to keep https://github.com/cap-js/attachments and this here in sync, I'd therefore suggest to add a section in "usage", e.g. "Run the example app provided in this repository", then link to the samples/README.md (where you briefly describe the commands for running the small sample bookshop app).
Then we need to add the same instructions to the cap-js application as well, you can possibly align with @eric-pSAP on this.

Copy link
Contributor

@lisajulia lisajulia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I have these requests:

  • Can you also add the README.md already? Then I would test to run this with the instructions you give there? Thanks :)
  • Since this is a sample application, it then replaces the sample application that is currently in cap-notebook, right? If so, remove the cap-notebook folder then, please.

@Schmarvinius Schmarvinius marked this pull request as ready for review November 10, 2025 17:16
@Schmarvinius Schmarvinius requested review from a team and lisajulia November 12, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants