-
Notifications
You must be signed in to change notification settings - Fork 4
Bookshop Sample #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bookshop Sample #672
Conversation
|
I want to write the README and think it would be a good idea to put the usage part of the root README into the sample. |
Hey @Schmarvinius :) |
lisajulia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, I have these requests:
- Can you also add the README.md already? Then I would test to run this with the instructions you give there? Thanks :)
- Since this is a sample application, it then replaces the sample application that is currently in cap-notebook, right? If so, remove the cap-notebook folder then, please.
I added the bookshop as a sample of how attachments can be implemented.