models/project.py: do not check for base when build-base: devel #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentindavid
force-pushed
the
valentindavid/do-not-check-devel-base
branch
from
5735bae to
a4f001b
Compare
To be able to build pc snap, we have to set the base to point to the upcoming base, in the present case `core26`, while using `build-base: devel`. This is how we worked on core24 before its release. Verifying the base matches the build base breaks it.
valentindavid
force-pushed
the
valentindavid/do-not-check-devel-base
branch
from
a4f001b to
cebf213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to build pc snap, we have to set the base to point to the upcoming base, in the present case
core26, while usingbuild-base: devel.This is how we worked on core24 before its release. Verifying the base matches the build base breaks it.
make lint && make test?docs/reference/changelog.rst)?