Rewrite button test to python to fix the issue of fail detect the IRQ if it not effect CPU0 (BugFix) #2047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the checkbox config var parser. Since the name of interrupts button could be include space or : Therefore, we use | to split the different button name. And also include fall back logic for the previous checkbox config var of the interrupts_button
rickwu666666
requested review from
weizhenwu,
seankingyang,
LiaoU3 and
stanley31huang
rickwu666666
added
the
ce-oem
rickwu666666
changed the title
rickwu666666
changed the title
rickwu666666
force-pushed
the
rewrite-button-test-to-python
branch
from
873b8fd to
5596abc
Compare
rickwu666666
force-pushed
the
rewrite-button-test-to-python
branch
from
5596abc to
910f7e3
Compare
rickwu666666
changed the title
This reverts commit b1f85cb. Since the GPIO related test not been affect, and also the GPIO test might be able to leverage from the gpio_control_test.py in PPC.
Since we split the gpio and interrupts button test
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/interrupts_button_test.py
Outdated
Show resolved
Hide resolved
stanley31huang
requested changes
Aug 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2047 +/- ##
=======================================
Coverage 51.66% 51.66%
=======================================
Files 386 386
Lines 41492 41492
Branches 7711 7711
=======================================
Hits 21435 21435
Misses 19294 19294
Partials 763 763 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| #!/usr/bin/env python3 | ||
| """ | ||
| A script to monitor interrupts, verify IRQ CPU affinity, and test | ||
| interrupt triggers via GPIO or manual sysfs interaction. |
There was a problem hiding this comment.
the interrupt should be triggers by sysfs only, not GPIO?
| return False | ||
| return True | ||
|
|
||
| def _get_interrupt_counts(self, irq_number: int) -> Optional[List[int]]: |
There was a problem hiding this comment.
I would suggest we could merge _get_irq_numbers and _get_interrupt_counts as it's pretty much the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrite button test to python to fix the issue of fail detect the IRQ if it not effect CPU0.
Our original design to check only the interrupt trigger for CPU0. However, that is not correct logic for the IRQ. The IRQ could be trigger for sepcific CPU, and it been defined in
/proc/irq/{irq_number}/smp_affinity.The new design will do following logic.
Resolved issues
https://bugs.launchpad.net/shiner/+bug/2098460
Documentation
Tests
button that support only one IRQ.
Trial run for the interrupt that support multiple IRQs
GPIO button