-
Notifications
You must be signed in to change notification settings - Fork 67
Secure boot state checking for Classic and Core no matter if the enable or disable (New) #1998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1998 +/- ##
==========================================
+ Coverage 50.60% 51.04% +0.43%
==========================================
Files 384 385 +1
Lines 41180 41553 +373
Branches 7636 7717 +81
==========================================
+ Hits 20841 21210 +369
+ Misses 19594 19593 -1
- Partials 745 750 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a185fd6
to
7fdb457
Compare
7fdb457
to
e1ba8bc
Compare
I've tried with my project which is
fail result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall just small things that can help simplify enum usage
Co-authored-by: Zhongning Li <[email protected]>
Tried with uc24/arm64/secure boot enabled platform. And test result were expected. pass result
Failed result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WARNING: This modifies com.canonical.certification::sru-server
Description
Current secure boot testing only validates enabled states, missing checkpoints when systems have secure boot disabled. This can allow systems to pass certification with configurations that don't match manifest expectations.
1. Dual Job Coverage
secure-boot-enabled
: Validates whenmanifest.has_secure_boot == 'True'
secure-boot-disabled
: Validates whenmanifest.has_secure_boot != 'True'
2. Enhanced Detection
/sys/firmware/efi/
path, usesmokutil
dumpimage
for image signature analysisFiles Modified
providers/base/units/miscellanea/jobs.pxu
- Job definitionsproviders/base/bin/check_secure_boot_state.py
- Script improvementsUsage
Resolved issues
Documentation
https://warthogs.atlassian.net/browse/OEMQA-6211
Tests
Testing on My Laptop: Ubuntu 22.04 Desktop Image with Secure Boot Enabled
checkbox-cli run com.canonical.certification::miscellanea/secure-boot-enabled com.canonical.certification::miscellanea/secure-boot-disabled
Testing on Baoshan: UC 22 Image with Secure Boot Disabled (UBOOT + UKI image with UEFI)
checkbox-baoshan.checkbox-cli run com.canonical.certification::miscellanea/secure-boot-enabled com.canonical.certification::miscellanea/secure-boot-disabled
Verify secure boot is enabled when manifest indicates support
will be skipped. It will run now since the manifest requirement is removed.Testing on Baoshan: Ubuntu 22 Image with Secure Boot Enabled
checkbox-baoshan.checkbox-cli run com.canonical.certification::miscellanea/secure-boot-enabled com.canonical.certification::miscellanea/secure-boot-disabled
Verify secure boot is disabled when manifest indicates no support
will be skipped. It will run now since the manifest requirement is removed.