add a check if wakealarm is supported (bugfix) #1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1921 +/- ##
=======================================
Coverage 50.47% 50.47%
=======================================
Files 382 382
Lines 41055 41055
Branches 6895 6895
=======================================
Hits 20722 20722
Misses 19587 19587
Partials 746 746
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This avoids a failing test and skips it instead if the rtc does not support an automatic wakeup.
aglinserer
changed the title
pieqq
requested changes
May 17, 2025
| @@ -251,7 +251,7 @@ category_id: com.canonical.plainbox::suspend | |||
| id: suspend/suspend_advanced_auto | |||
| requires: | |||
| sleep.mem == 'supported' | |||
| rtc.state == 'supported' | |||
| rtc.state == 'supported' and rtc.wakealarm == 'supported' | |||
There was a problem hiding this comment.
Suggested change
| rtc.state == 'supported' and rtc.wakealarm == 'supported' | |
| rtc.state == 'supported' | |
| rtc.wakealarm == 'supported' |
You can just place the new requirement on another line and it acts as an and (see doc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This avoids a failing test and skips it instead if the rtc does not support an automatic wakeup.
The
suspend_advanced_autojob is failing even though it cannot be run when the wakealarm is not supported.Resolved issues
N/A
Documentation
N/A
Tests
N/A