-
Notifications
You must be signed in to change notification settings - Fork 60
Add named attribute access to gnome-monitor.py
(New)
#1916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomli380576
wants to merge
23
commits into
main
Choose a base branch
from
typed-gnome-monitors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b37882d
to
7e759db
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1916 +/- ##
==========================================
+ Coverage 50.46% 50.83% +0.37%
==========================================
Files 382 383 +1
Lines 41039 41423 +384
Branches 6892 6957 +65
==========================================
+ Hits 20709 21058 +349
- Misses 19585 19607 +22
- Partials 745 758 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gnome-monitor.py
(New)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds complete type annotations and named properties to the original gnome-monitors script to hopefully make it more ergonomic to use. It's not something that needs to be urgently merged so don't worry about this if you have a fire to fix xD
Basically turns this:
into this:
with nice IDE autocomplete.
#1843 could take advantage of this to more directly access resolution numbers instead of strings
Resolved issues
In the original
MonitorConfigGnome
, accessing deeply nested properties from theGetCurrentState
's return value was a bit awkward. If we need to get the 1st refresh rate of the 1st monitor, we need to writestate[1][1][0][1][0][3]
which looks like magic numbers without looking at the original dbus xml. The originalMonitorConfigGnome
provided nice ways to get the resolution strings but all the other properties were not included.This PR circumvents this magic index situation by providing named attribute access for the return value of
GetCurrentState
, so now we can writestate.physical_monitors[0].modes[0].refresh_rate
and only use indices in places where there's an actual array.Documentation
The main reference point is this xml and gnome-randr
None of the new classes (MutterDisplayConfig, PhysicalMonitor, LogicalMonitor, MonitorInfo) should be directly constructed because they assume that the input GLib.Variant has the correct type. Use
MonitorConfigGnome.get_current_state()
as the entry point since it asks GLib to do a deep type check first before returning.Tests
Original unit tests