Pin dependencies for source installs of checkbox (bugfix) #1912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook25
force-pushed
the
pin_checkbox_ng_deps
branch
from
9bb95dd to
4c017d2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1912 +/- ##
=======================================
Coverage 50.46% 50.46%
=======================================
Files 382 382
Lines 41039 41039
Branches 6892 6892
=======================================
Hits 20709 20709
Misses 19585 19585
Partials 745 745
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Given the recent urwid debacle taking down our infra, its about time we take seriously source installs of Checkbox. Checkbox source IS part of our infra, it is not a development tool anymore. As such, the distribution of it must be fixed.
This is the first step: all packages are pin to the same version one can find them in the universe of each LTS (some excluding xenial, given that xenial doesn't offer them, they are instead pinned for compatibility with python3.5).
Resolved issues
Documentation
Documented each pinning block what it is referring to.
Tests
Metabox run: https://github.com/canonical/checkbox/actions/runs/14886986668/job/41809138279