Automate wake-on-LAN tests (New) #1819
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please refer to wake-on-LAN-automatic-tests.md for more details Co-authored-by: hanhsuan <[email protected]>
… checkbox. This is because it's not directly called by checkbox and introduces an unnecessary dependency on FastAPI.
…ues on some older python versions. Fix some issues per Stanley's review Add the related unit tests after code changes
Move inline function out of get_ip_mac per Stanley's comments
use more specific 4xx or 5xx status code from wol_server Co-authored-by: stanley31huang <[email protected]>
Check the return value when get the timestamp to prevent unexpected exception Update related unit tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1819 +/- ##
==========================================
+ Coverage 49.93% 50.17% +0.23%
==========================================
Files 378 380 +2
Lines 40766 40962 +196
Branches 6859 6883 +24
==========================================
+ Hits 20356 20552 +196
Misses 19683 19683
Partials 727 727
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eugene-yujinwu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a clone PR of #1686.
The 1686 was not reviewed by Cert team, and it was reverted and this PR was re-submitted for review.
Please refer more detailed info in the #1686.
Thank you.
Resolved issues
Documentation
Tests