-
Notifications
You must be signed in to change notification settings - Fork 60
General purpose camera pipeline in checkbox_support (New) #1741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomli380576
wants to merge
23
commits into
main
Choose a base branch
from
camera-pipelines-part1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
+ Coverage 49.26% 49.81% +0.55%
==========================================
Files 373 377 +4
Lines 40434 40931 +497
Branches 6830 6930 +100
==========================================
+ Hits 19921 20391 +470
- Misses 19785 19793 +8
- Partials 728 747 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(This PR is the 1st part of the previously implemented automatic gstreamer pipeline PR that was too big)
This PR adds a general purpose pipeline runner
run_pipeline
in checkbox_support and an example driver codetake_photo
that takes a photo using this runnerResolved issues
#1676 <-- was too big for review. The end goal is to have a test job that can enumerate every (device, capability) combination returned by gst-device-monitor and check if each combination can take a photo/record a video/show a viewfinder
Documentation
I drafted a short design doc to explain some of the weirdness/quirks in the code that might not be fully explained by the comments. Hopefully this helps with the review :)
Tests
Unit tests. Also tested on real devices with USB cameras using the following driver code
Intel MIPI are expected to fail for now since they are only accessible with v4l2src, which isn't exposed in DeviceMonitor. (aside: I think the desktop team is currently backporting this fix from pipewire, if this gets backported then MIPIs will all work without special treatment or explicitly using v4l2src)
This also plays well with checkbox timeout: