dashboard: make media and performance panels toggleable #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMHO the media and performance tabs are largely redundant, but I'm sure there are those that appreciate the additional information, so I made them optional via config, defaulting to "on" to preserve the current user experience. This is pretty messy, and I'm sure there are smarter/cleaner ways to do what I'm trying to accomplish, but it works, more or less (there's some minor layout jitter on first run). |
mhydock
force-pushed
the
feature/toggle-dashboard-panels
branch
5 times, most recently
from
a25646a to
d823364
Compare
mhydock
force-pushed
the
feature/toggle-dashboard-panels
branch
2 times, most recently
from
a4b977c to
1fc1df4
Compare
added two config options in the dashboard section to enable/disable the media tab and the performance tab. if both are disabled, the tab bar in the dashboard is hidden. still a bit of jerkiness when config values resolve, not sure how to fix that. also, the way i'm conditionally showing panels is kinda janky, i'm sure there are better ways to do this...
mhydock
force-pushed
the
feature/toggle-dashboard-panels
branch
from
1fc1df4 to
360c335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two config options in the dashboard section to enable/disable the media tab and the performance tab. If both are disabled, the tab bar in the dashboard is hidden.