Asset + Marketplace Contract #81

Peartes · 2025-09-16T16:23:00Z

This is the Asset standard Contract. Details on the design is here

ash-burnt · 2025-10-23T18:16:21Z

contracts/asset/src/execute/reservation.rs

+    }
+
+    listing.reserved = Some(Reserve {
+        reserver: reservation.reserver.clone(),


This is an unsafe call. Addr types are not sanitized from msgs. Even though the type is set, the address might be invalid, and needs to be checked

ash-burnt · 2025-10-23T18:17:40Z

contracts/asset/src/state.rs

+
+#[cw_serde]
+pub struct Reserve {
+    pub reserver: Addr,


Addr types are good for state storage, but not good for msg types, because of their lack of sanitization. You probably can't reuse the state definition for the msg definition. Also, you likely want to make the reserver optional, and if unset, uses the msg sender

ash-burnt · 2025-10-23T18:20:16Z

contracts/asset/src/execute/sale.rs

+        .iter()
+        .find(|coin| coin.denom == price.denom)
+        .ok_or_else(|| ContractError::NoPayment {})?
+        .clone();


What happens if multiple coins are sent? Seems like everything other than the first match will be stuck in the contract. If only one token is expected, it should be enforced

Adjusted to fail the tx if multiple coins are sent

ash-burnt · 2025-10-23T18:22:53Z

contracts/asset/src/execute/sale.rs

+        .ok_or_else(|| ContractError::NoPayment {})?
+        .clone();
+
+    if payment.amount.lt(&price.amount) || payment.denom != price.denom {


This checks if you underpaid, which is good, but does not check if you overpaid. Do we intend to let people overpay? If so, that will need to be explicitly documented

we have an exact price plugin that can be set to enforce the exact price of an asset is sent. If this isn't set, only underpayments are considered. Should we fail on overpayments regardless ?

ash-burnt · 2025-10-23T18:24:08Z

contracts/asset/src/execute/listing.rs

+    id: String,
+    price: Coin,
+    reservation: Option<Reserve>,
+    marketplace_fee_bps: Option<u16>,


This initialism is never defined anywhere. I don't know what it means

this is sent in the listing msg and is the marketplace fee in basis point

we removed this marketplace fee from the asset

ash-burnt · 2025-10-23T18:25:15Z

contracts/asset/src/execute/listing.rs

+        });
+    }
+
+    let (validated_marketplace_fee_bps, validated_marketplace_fee_recipient) =


Seems like these marketplace values can be set by the lister. How do they interact with the marketplace? Why would someone listing an asset set them?

an individual listing an item would not set this. This is strictly for scenarios where marketplaces are the ones listing and want to set a fee

ash-burnt · 2025-10-23T18:26:25Z

contracts/asset/src/execute/reservation.rs

+
+    listing.reserved = Some(Reserve {
+        reserver: reservation.reserver.clone(),
+        reserved_until: reservation.reserved_until,


Is there any bound on this value? Or can I just reserve something for 10,000,000 years?

there is a time lock plugin that sets the maximum duration an asset can be reserved for and is enforced upon reservation but if the time lock plugin is not set, the asset can be reserved indefinitely until unreserved by the owner or approvals

ash-burnt · 2025-10-23T18:27:46Z

contracts/asset/src/execute/sale.rs

+        .add_attribute("price", price.amount.to_string())
+        .add_attribute("denom", price.denom)
+        .add_attribute("seller", seller.to_string())
+        .add_attribute("buyer", buyer.to_string());


this doesn't include all of the data necessary for backing out the pricing. marketplace configuration args should be output here as well

they are included early if the marketplace config was set or not at all

- fail tx when multiple coins are set to make sure coins aren't stuck in contract - make sure Abstract types without sanitation enforced aren't used in msgs and then directly for logic

* chore: add in base spec msgs * chore: asset method trait * chore: implement default plugins * chore: listing an asset * chore: more coverage on Listing * chore: delist and buy WIP on timelocks * chore: unit test on delist * chore: reserve and reserve unit test * chore: more generic contract * feat: add in default plugins * feat: add in test and asset-base contract * chore: disable raw transfer if royalty is set * feat: add in query messages * fix: remove default features for asset-base * feat: make sure deductions are made in sellable buy logic * chore: add in query impl into asset-base contract * format toml * add marketplace to lockfile * add cw-address-like * add contract * update marketplace * add queries * add tests * move offers * add item-sold event * complete buy * offers * add more tests * remove unused * accept offer * change to queue * set fee recipient and update config by manager * chore: remove unwrap() * fix: proper seller is owner * fix linting * check listing is tied to seller * add justfile * fix clippy issues * add royalty test * Merge pull request #86 from burnt-labs/feature/marketplace-approval add approve/reject * update cargo file, finalize for and split execute * account for marketplace fees --------- Signed-off-by: Kehinde Faleye <[email protected]> Co-authored-by: peartes <[email protected]>

* handle asset price * split tests * fix tests * fix lint * format code

* fix fee on approval * apply fee on accept offer * format * add tests * update test and approval --------- Co-authored-by: Kehinde Faleye <[email protected]>

* fmt code * handle linter fixes for account, user map and treasury contracts * handle asset lint issues * format code

Peartes requested review from ash-burnt, jburnt and justinbarry September 16, 2025 16:23

Peartes self-assigned this Sep 16, 2025

Peartes added the enhancement New feature or request label Sep 16, 2025

Peartes marked this pull request as ready for review October 20, 2025 14:15

Peartes added 21 commits October 20, 2025 15:16

chore: add in base spec msgs

41c3b55

chore: asset method trait

bc24788

chore: implement default plugins

1e87145

chore: listing an asset

17d7f78

chore: more coverage on Listing

9f98bbb

chore: delist and buy WIP on timelocks

8d54490

chore: unit test on delist

2ae6404

chore: reserve and reserve unit test

28202bd

chore: more generic contract

1a79252

feat: add in default plugins

66bb6f8

feat: add in test and asset-base contract

ff913f7

chore: disable raw transfer if royalty is set

c3bb0e4

feat: add in query messages

4990ceb

fix: remove default features for asset-base

8e90679

feat: make sure deductions are made in sellable buy logic

c625737

chore: add in query impl into asset-base contract

3f17a32

chore: remove unwrap()

7ae4e43

fix: proper seller is owner

6e08cb7

chore: remove the on_primary for royalty plugin

900a0ca

chore: add unreserve endpoint to asset contract

2458ea5

chore: use Timestamps instead of Expiration for reserve

d0c79a7

Peartes force-pushed the feat/xion-asset branch from be618c1 to d0c79a7 Compare October 20, 2025 14:16

Peartes changed the title ~~chore: add in base spec msgs~~ chore: add in xion asset base spec msgs Oct 20, 2025

chore: allow de-listing a reserved asset

8c8330d

Peartes added 7 commits October 20, 2025 16:21

fmt: linting

4162d04

fmt: cargo fmt

c99b9ee

fix: undeclared imports

7d4e4a6

chore: refractor

2c122cf

fmt: cargo fmt

e30f5c8

fmt: clippy

af491a3

chore: refractor

d34cb59

ash-burnt requested changes Oct 23, 2025

View reviewed changes

Peartes and others added 8 commits October 24, 2025 15:51

chore:

8375cf3

- fail tx when multiple coins are set to make sure coins aren't stuck in contract - make sure Abstract types without sanitation enforced aren't used in msgs and then directly for logic

chore: add in marketplace details in emitted events

4a70034

fix: failing test

386d6df

chore: gate collection msg to collection owner

fd495d5

chore: remove marketplace fee

31140d9

fix: asset base contract

5403d6d

update marketplace fee and tests (#88)

39c002e

* handle asset price * split tests * fix tests * fix lint * format code

Peartes requested a review from ash-burnt October 29, 2025 16:16

Peartes and others added 3 commits October 30, 2025 16:21

fix: stale listing and stale reservation

a6c03de

fee fixes (#89)

c0f60d8

* fix fee on approval * apply fee on accept offer * format * add tests * update test and approval --------- Co-authored-by: Kehinde Faleye <[email protected]>

xion asset lint fixes (#90)

554fa7d

* fmt code * handle linter fixes for account, user map and treasury contracts * handle asset lint issues * format code

justinbarry changed the title ~~chore: add in xion asset base spec msgs~~ Asset + Marketplace Contract Nov 10, 2025

Asset + Marketplace Contract #81

Are you sure you want to change the base?

Asset + Marketplace Contract #81

Conversation

Peartes commented Sep 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants