Update EC2 tags/metadata to use AWS Go SDK v2 #3434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
agent-aws-go-sdk-v2
branch
3 times, most recently
from
5dd2fd8 to
97f8810
Compare
DrJosh9000
force-pushed
the
agent-aws-go-sdk-v2
branch
from
97f8810 to
15631b0
Compare
rahdjoudj
reviewed
Oct 13, 2025
| } | ||
|
|
||
| svc := ec2.New(sess) | ||
| svc := ec2.New(ec2.Options{}) |
There was a problem hiding this comment.
don't we need to pass the config here ? to it can access the instance tags ?
smth like svc := ec2.NewFromConfig(cfg)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update EC2 tags/metadata to use AWS Go SDK v2
Context
Noticed while looking at linter output that AWS Go SDK v1 is now no longer supported.
Changes
Update to the v2 SDK. This only updates calls within the agent package, other packages to come soon.
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)Disclosures / Credits
I did not use AI tools at all.