HASH Discard Rule #2318
Merged
HASH Discard Rule #2318
+828
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Android notifier sizes
Generated by 🚫 Danger |
…h discard rule serialization
lemnik
force-pushed
the
PLAT-15072/hash-discard-rule
branch
from
18a6537 to
f8120cc
Compare
lemnik
force-pushed
the
PLAT-15072/hash-discard-rule
branch
from
f8120cc to
116fd9b
Compare
lemnik
force-pushed
the
PLAT-15072/hash-discard-rule
branch
from
aefc51e to
664580b
Compare
…ig with an empty ruleset until the next check time
lemnik
force-pushed
the
PLAT-15072/hash-discard-rule
branch
from
6259c7e to
f5c602c
Compare
…erver to either define whether the etags are expected quoted or not
lemnik
force-pushed
the
PLAT-15072/hash-discard-rule
branch
from
f49b7d5 to
7c7f4ad
Compare
…down to 0, remoteconfig expires exactly when the Cache-Control header says it does
lemnik
force-pushed
the
PLAT-15072/hash-discard-rule
branch
from
7e12c23 to
b6dd888
Compare
…, rather than the payload itself
lemnik
force-pushed
the
PLAT-15072/hash-discard-rule
branch
from
b6dd888 to
339a8f4
Compare
...ag-android-core/src/main/java/com/bugsnag/android/internal/remoteconfig/RemoteConfigState.kt
Show resolved
Hide resolved
DariaKunoichi
previously approved these changes
Nov 7, 2025
tomlongridge
previously approved these changes
Nov 12, 2025
lemnik
dismissed stale reviews from tomlongridge and DariaKunoichi
via
6b5958a
…at the first unusable frame
DariaKunoichi
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Introduce the
HashDiscard rule to theRemoteConfigcapabilities.Changes
Hashdiscard rule to theRemoteConfigclassHashobjects do not parse theirDiscardRulecontent until they are first usedAllandAllHandleddiscard rules to be objects instead of classesTesting
Added new unit tests for the
Hashparsing and serialization. Also tested manually.