Skip to content

Fix bug in tag overflow checks #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix bug in tag overflow checks #19

wants to merge 3 commits into from
+20 −1

Conversation

marcoferrer
Copy link

#18

@doriable doriable changed the title bug fix tag overflow checks Fix bug in tag overflow checks Aug 14, 2025
mcy
mcy reviewed Aug 18, 2025
View reviewed changes
Copy link
Member

@mcy mcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please expand the PR description to detail why this change is necessary. I prefer to have detailed commit messages that are self-contained.

internal/tdp/tag_test.go

func TestTagOverflows(t *testing.T) {
tag := EncodeTag(protowire.MaxValidNumber, protowire.BytesType)
if tag.Overflows() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use assert.True() here.

@mcy
Copy link
Member

mcy commented Aug 18, 2025

Also, could you include a test in internal/testdata/tags that exercises this behavior? I like to have end-to-end tests for these kinds of corner-cases.

mcy
mcy reviewed Aug 18, 2025
View reviewed changes
internal/tdp/tag_test.go
@@ -0,0 +1,13 @@
package tdp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tdp -> tdp_test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcy mcy mcy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoferrer @mcy