Skip to content

fix: avoid duplicate iframe children cloning #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: avoid duplicate iframe children cloning #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/clone-node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,6 @@ async function cloneChildren<T extends HTMLElement>(

if (isSlotElement(nativeNode) && nativeNode.assignedNodes) {
children = toArray<T>(nativeNode.assignedNodes())
} else if (
isInstanceOfElement(nativeNode, HTMLIFrameElement) &&
nativeNode.contentDocument?.body
) {
children = toArray<T>(nativeNode.contentDocument.body.childNodes)
} else {
children = toArray<T>((nativeNode.shadowRoot ?? nativeNode).childNodes)
}
Expand Down
17 changes: 17 additions & 0 deletions test/resources/iframe/node.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<iframe
srcdoc="'
<!DOCTYPE html>
<html>
<body>
<div>
SOME TEXT
<div>SOME MORE TEXT</div>
</div>
</body>
</html>
'"
width="600"
height="400"
>
Fallback content
</iframe>
7 changes: 7 additions & 0 deletions test/spec/special.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,11 @@ describe('special cases', () => {
.then(done)
.catch(done)
})

it('should render iframe content', (done) => {
bootstrap('iframe/node.html')
.then(assertTextRendered(['SOME TEXT', 'SOME MORE TEXT']))
.then(done)
.catch(done)
})
})
Loading