-
Notifications
You must be signed in to change notification settings - Fork 0
Video transcript block #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 61893 lines exceeds the maximum allowed for the inline comments feature.
using the useRef hook to send a reference to the player element to the button in the captions.
and enable controls by default
more reliable to target the underlying player. The youtube seekTo() function really needs the second 'true' argument to function well.
This initial implementation just grabs the first available track, but this could be the basis for a caption track picker.
Video ID block input and react front end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 51171 lines exceeds the maximum allowed for the inline comments feature.
Alignment options and responsive styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 70353 lines exceeds the maximum allowed for the inline comments feature.
…nfig # Conflicts: # build/blocks.css # build/blocks/blocks.build.asset.php # build/blocks/blocks.build.js.map # build/blocks/blocks.css.map # build/frontend/frontend.build.asset.php
Maybe swap entry point method to better use wp-scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 31628 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 31629 lines exceeds the maximum allowed for the inline comments feature.
|
Code Climate has analyzed commit 046b2e6 and detected 0 issues on this pull request. View more on Code Climate. |
This pull request introduces a basic video transcript block using a YouTube ID and makes some initial progress on #115.