Skip to content

Add new line after seeds.rb when appending #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add new line after seeds.rb when appending #3

wants to merge 1 commit into from

Conversation

RoopeHakulinen
Copy link

I ran to a problem while adding bcms_news after bcms_event to my BrowserCMS-project. The seeds.rb appendings go to same line and that gives an error while trying to run rake db:install. There is no issue if you don't add any other modules that append this file after bcms_event.

Unlike other modules, bcms_event didn't seem to add new line (\n) after

load File.expand_path('../bcms_news.seeds.rb', __FILE__)

so I added it there. Other modules I am referring to are
bcms_news (https://github.com/browsermedia/bcms_news/blob/master/lib/generators/bcms_news/install/install_generator.rb)
and bcms_feeds (https://github.com/browsermedia/bcms_feeds/blob/master/lib/generators/bcms_bmedia_feeds/install/install_generator.rb).

This is my first pull request ever, so if there is something I could have done different or better, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant