improvement of residual-chart hover info #579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…R app name up front
- app.json is only read when FIRST CREATED, future deploys do not read it - All values must be strings
Intended for embedding use cases, the type is:
type InitialState = {
editorContents: string,
interactionsSinceLastRun: string
}
On load the editor will automatically run definitions with the given
text and then run all the given interactions.
Currently only enabled in embedding contexts.
Need state for two more cases:
- Editing definitions but haven't run at all yet
- Editing definitions after a run
Co-authored-by: Irv Katz <[email protected]>
One thing that's challenging is the use of on('change') on CodeMirror,
which triggers for calls to setValue().
In the events API, we change these to all use replaceRange with an
explicit `origin`. However, there are setValue() calls elsewhere in the
codebase. We could ignore these by checking the origin of "setValue",
but this could be a mistake if we do want to propagate around updates
like those. Need to think about this.
For now, filter out ones that come in before we are initialized, and
wait for the reset event to start sending things out. This makes sure
that the initialization of setting e.g. `use context current` doesn't
get sent out as an event.
Sometimes we get "empty" resets from VMT, and this commit just filters
those out. But it's not clear when exactly that happens.
- Don't propagate setvalue events; these are coming from page setup, but we want to wait for our 'reset' - Don't setValue at all if the page is “controlled”. Add a new #-parameter #controlled=true that tells the page to not do its usual initialization and instead wait for the reset events - The first 'reset' has a state of '', so deal with that appropriately to handle initialization in events.js
… and try running all tests
Port in .env.example is now 4999; fix README.md
…at. move up AWS stuff for faster test
Trying to only run AWS stuff if PR (not sure what happens if it's a push to an existing PR, see https://stackoverflow.com/questions/66205887/only-run-github-actions-step-if-not-a-pull-request)
One more conditional-on-PR-step
|
I'm closing this PR as obsolete (and also much too big and conflicting to merge cleanly anymore). There appear to be three commits that were relevant: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.