Optimize FlatMultiMapBuilder #551
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: 19e0a1a | Previous: fca4bc5 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2389049477 ns/iter (± 27996261) |
2217231164 ns/iter (± 9972499) |
1.08 |
rule-match-first-request/brave-list |
1188050 ns/iter (± 43091) |
1138984 ns/iter (± 12605) |
1.04 |
blocker_new/brave-list |
166610439 ns/iter (± 3191068) |
165009583 ns/iter (± 313867) |
1.01 |
blocker_new/brave-list-deserialize |
30143929 ns/iter (± 2171638) |
23484976 ns/iter (± 262551) |
1.28 |
memory-usage/brave-list-initial |
10212240 ns/iter (± 3) |
10212224 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-initial/max |
63146615 ns/iter (± 3) |
62256247 ns/iter (± 3) |
1.01 |
memory-usage/brave-list-initial/alloc-count |
1231572 ns/iter (± 3) |
1362325 ns/iter (± 3) |
0.90 |
memory-usage/brave-list-1000-requests |
2666974 ns/iter (± 3) |
2666958 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests/alloc-count |
71385 ns/iter (± 3) |
71369 ns/iter (± 3) |
1.00 |
url_cosmetic_resources/brave-list |
205107 ns/iter (± 1079) |
202616 ns/iter (± 728) |
1.01 |
cosmetic-class-id-match/brave-list |
3357191 ns/iter (± 915799) |
3413013 ns/iter (± 963790) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
atuchin-m
force-pushed
the
optimize-FlatMultiMapBuilder
branch
from
69c3ba0 to
e2e724c
Compare
atuchin-m
force-pushed
the
optimize-FlatMultiMapBuilder
branch
from
e2e724c to
19e0a1a
Compare
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: 19e0a1a | Previous: fca4bc5 | Ratio |
|---|---|---|---|
blocker_new/brave-list-deserialize |
30143929 ns/iter (± 2171638) |
23484976 ns/iter (± 262551) |
1.28 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-10% alloc count, -5-10% building time.
Before:
After:
