Skip to content

Conversation

@snaka
Copy link
Contributor

@snaka snaka commented Sep 11, 2025

Motivation / Background

This Pull Request has been created because the CI test matrix needed to be expanded to include Ruby 3.4 and Rails 7.2 support, and there was a compatibility issue with hash output formatting across different Ruby versions that was causing RSpec test failures.

Detail

This Pull Request changes:

  1. CI Test Matrix Expansion: Adds Ruby 3.4 and Rails 7.2 to the GitHub Actions test matrix to ensure compatibility with newer versions
  2. Ruby Version Compatibility: Fixes hash output format in RSpec matcher tests to work consistently across Ruby versions by using #inspect method instead of string interpolation
  3. Rails 7.2 Support: Adds Gemfile.rails72 configuration file to support Rails 7.2 stable branch testing

- Add Ruby 3.4 to the test matrix
- Add Gemfile.rails72 to test configurations
- Replace hardcoded hash strings with dynamic hash.inspect in RSpec matcher tests
- Ensures test assertions work correctly with different Ruby hash formatting
@snaka
Copy link
Contributor Author

snaka commented Sep 12, 2025

@nashby nashby merged commit 4084ab4 into brainspec:master Sep 12, 2025
120 checks passed
@nashby
Copy link
Member

nashby commented Sep 12, 2025

@snaka thanks!

@snaka snaka deleted the ci/expand-test-coverage branch September 12, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants