-
Notifications
You must be signed in to change notification settings - Fork 45
Update cnc-ddraw.yml #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update cnc-ddraw.yml #290
Conversation
New repo FunkyFr3sh/cnc-ddraw: previous from CnCNet/cnc-ddraw no longer exists. Updated from v4.4.8.0 to v7.0.0.0
I chose v7.0 in favor of v7.1 as I encountered a black screen issue in StarCraft Classic with the most recent one. I'm filing an Issue there to get it fixed, then this dependency could be updated when v7.2 or v7.3 releases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. It's looking good, except the shaders. I've looked into the new zip file, and there are new shaders that won't be matched by the glob *.glsl
because they are named .glsl.pass1
for a couple multi-pass shaders. I think all the globs should be changed to something like *.*
or maybe even just *
if that works because we really want to copy all files in these folders no matter what they are called.
Also, a couple shaders were removed in this release. The cubic
and windowed
folders don't exist anymore.
archive_extract returns an error code 2 with most zip provided by FunkyFr3sh/cnc-ddraw. Seems to be related to 'cnc-ddraw config.exe' being extracted as a directory and crashing 7z. A solution would be to append an argument to extract only a selection of files and avoid the one crashing, but I cannot figure out this action. As an alternative, cnc-ddraw-experimental-debuglog.zip does not contain the problematic exe and the extraction is successful, although without Shaders. The priority is still to provide a working dll for software requiring it, while Shaders are not necessary.
Sorry for not testing using a local repo earlier: I thought it would be a simple url fix. |
Sorry for more changes, I realized I made some mistakes:
I'm preparing to file an issue for https://github.com/flathub/com.usebottles.bottles/blob/master/com.usebottles.bottles.yml to use another version of 7-zip, and the extract bug should be resolved. |
New repo FunkyFr3sh/cnc-ddraw: previous from CnCNet/cnc-ddraw no longer exists. Updated from v4.4.8.0 to v7.0.0.0
Fixes #289
Type of change
Was this tested using a local repository?