-
-
Notifications
You must be signed in to change notification settings - Fork 40
Adding missing files to Docs, and fixes #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: docs
Are you sure you want to change the base?
Conversation
fix link to Command Line Options
Fix reference to Command Line Options and parentheses - add --ignore-case for clarity?
Updated output of -h with that of the latest version, changed indentation for easier comparison with the old text
Fix outdated links and formatting issues
Is this feature present? No examples or documentation even show how it would be used
fixing up some small inconsistencies between files
Initial proposal to document this library
Additions for consistency and clarity
Initial proposal based on INPUT and the INPUT42 source file
Add Declare to function and sub doc pages See Also
Start of TO keyword documentation
boriel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this!! 🤗
Please, review my comments before I merge.
docs/library/hex.md
Outdated
|
|
||
| ```basic | ||
| A$ = hex(n32) | ||
| B$ = hex(n16) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these be
B$ = hex16(n16)
C$ = hex8(n8)??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are correct! Missed that
docs/operators.md
Outdated
| Logicals operators are like in ZX Spectrum Basic. Their result can be either _False_ (which is represented with 0) | ||
| or _True_, which might be any other value. <u>Don't expect _True_ value number to be always **1**</u>. | ||
| If you need 0/1 values for boolean evaluations, use `--strict-boolean` [compiler option](zxb.md#Command Line Options). | ||
| If you need 0/1 values for boolean evaluations, use `--strict-boolean` [compiler option](zxb.md#command-line-options). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--strict-boolean is deprecated (currently ignored), and soon will be an error using it!
Booleans are now always normalized! Maybe this line shuold be removed or in the command line options page specify it's deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can delete this line then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I'll edit zxb.md as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed,
which might be any other value. Don't expect True value number to be always 1
is no longer valid. Now it should read
Their result can be either False (which is represented with 0) or True (represented by 1).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also done!
Incorporate corrections from Boriel
Incorporate suggestions from Boriel
Add corrections by Boriel
|
Oops |
Add corrections by Boriel
Several small fixes to various files, as wel as creating the hex.md and input42.md pages that were missing