Release/4.2 #1619
Merged
Release/4.2 #1619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes incorrect header being included, which also broke C++11 compatibility.
4.2: Fix an invalid include, restore C++11 compatibility
…trackgenerator Cherrypick commits for release/4.2, that include transitivity fix for DsfTrackGenerator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged the cherry-pick needed for gtsfm, and decided this would be a good time to finally release 4.2. It's been a long time coming. After merging into master, I will tag master with 4.2 and create a release. Please let me do this as I'd like to add some context in release notes.
@varunagrawal I was not able to build python 4.11 with gtsam-manylinux and sent some emails about it. I'd like to understand the docker image used although it might not be related to that. We should probably build the docker images for 4.2 and upload those to docker with the correct version number.