Increase archive_tag.ui maximum keep_ limit.

[max-foss]

Description

I increase the keep_hourly, keep_daily, keep_weekly, keep_monthly and keep_yearly to a higher but still sane number, I chose 65535.

Related Issue

#2280

Motivation and Context

I wanted to apply this regimen (in borgmatic-syntax for simplicity) to my backups and it wasn't possible before:

keep_daily: 365 # 1 year
keep_weekly: 1095 # 3 years
keep_monthly: 3650 # 10 years

How Has This Been Tested?

Code review and thorough test of application after change.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have read the CONTRIBUTING guide.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

[madeddy]

Its a hard no from my side to this change.

• The proposed numbers are totally blown out of proportion (65535 days of backups instead 999? Really?)
• Reasoning for the change is unconvincing
• That PR/commit is NOT a bugfix

[max-foss]

Well, there is no limit in upstream borg, so why do we have one here?

This is my use case, I don't need more than that, maybe we can put 9999 in or some other number of your discretion accomadating this:

It breaks my way of using vanilla Borg/Borgmatic, hence why I considered it a bug.

[madeddy]

It breaks my way of using vanilla Borg/Borgmatic, hence why I considered it a bug.

Ok, i can see your view point if you look at it like this.

Maybe they limited for some reason. Could be some size limit in a database or a Vorta dependency or what. The strange numbers, just shy of the next bit, make me pause. Lets see if someone more involved can tell more about this, but it should also be this old issue considered: #1082.

[max-foss]

I have used this branch extensively and there seem to be no regressions of any kind.

I assume the default values are an artifact of either Qt Creator or Qt Designer as recommended to be used here: https://vorta.borgbase.com/contributing/#working-on-the-gui

[max-foss]

Ahh, it looks like the old PR is not yet in the version released when you do brew install --cask vorta, there I ended up with 99 weekly and 99 monthly which is not nearly enough and I forgot trying the master without any changes.

My apologies 🫠

[madeddy]

I forgot trying the master without any changes.

My apologies 🫠

No worries. 👋🏻