A better way to show Borg's errors #2221
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1940
I think it would be better to show Borg's error messages inside Vorta's exception dialog instead of relying on the tiny progress event box.
Now most of Borgs' commands would have a "started" and "finished" messages appears in the progress event box, and the errors would appear in the exception dialog.
I also added
finished_event
function tomount
andumuont
, I'm not sure but I think it should have error handling also, just as the rest of the commands.Now the command that doesn't have that change are
info_archive
,info_repo
,init
,version
, andrename
.Related Issue
#1940
How Has This Been Tested?
I tested it by changing Borg's commands from the source code to force them to fail and return non-zero code, and the result for all the commands is just like the screen record.
Screen Record:
2025-03-20.03-14-30.mp4
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.