Fix GUI Freezing while running pre-backup command #2214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3nu
previously approved these changes
Mar 10, 2025
|
Elegant solution. Well done! |
|
Minor issue with formatting. Did you use the pre-commit hooks? |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the GUI freezing bug while running pre-backup command, if the command takes time, the GUI freezes until the command finishes.
Related Issue
Fixes #210
How Has This Been Tested?
I tested the change using a couple of scripts, and I made sure that the script itself will finish completely before backup starts executing.
Screenrecord:
2025-03-08.23-35-05.mp4
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.