Skip to content

Made clarity changes to exclude dialog #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

VandalByte
Copy link
Collaborator

Description

This PR adds more clarity to the exclude dialog by specifying that exclusion uses file name pattern matching (fnmatch) by default. It also updates the title to "Exclude Files and Folders" for better user understanding.

Related Issue

Resolves #2104

How Has This Been Tested?

Tested the UI by running the build

Screenshots:

Previous
image

New
Screenshot 2025-02-20 212520

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@m3nu
Copy link
Contributor

m3nu commented Mar 5, 2025

I'm not sure the new tab title is the most descriptive. Since the other tabs also exclude files and folders.

I don't have a better suggestion right now, but maybe all the tab titles should be considered in their context.

@VandalByte
Copy link
Collaborator Author

@m3nu
Some other titles I can think of is Custom Exclusions, Exclude Patterns, Manual Exclusions, Pattern or just keep it as Custom with only the description change as suggested by goebbe

@m3nu
Copy link
Contributor

m3nu commented Mar 5, 2025

I'd use "Exclude Patterns". Since they aren't individual files and folders only. It also fits the text description below.

@VandalByte
Copy link
Collaborator Author

I'd use "Exclude Patterns". Since they aren't individual files and folders only. It also fits the text description below.

I have changed the title to Exclude Patterns, it does seem like the best option in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify exclude vs patterns setting in Exclude UI
2 participants