Skip to content

Conversation

@ckyrouac
Copy link
Collaborator

Assisted-by: Claude Code

@github-actions github-actions bot added the area/documentation Updates to the documentation label Oct 30, 2025
@bootc-bot bootc-bot bot requested a review from gursewak1997 October 30, 2025 19:26
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the new experimental bootc install reset command. The new documentation is clear and well-structured, providing a good overview, usage examples, and details on the feature. I've identified one issue in a command example for cleaning up old stateroots and have provided a correction.

ls -la /sysroot/ostree/deploy/

# Remove the old stateroot (replace 'default' with your old stateroot name)
sudo ostree admin stateroot-init --delete default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The command provided for cleaning up an old stateroot appears to be incorrect. ostree admin stateroot-init is used for initializing a stateroot, not deleting one. The correct command to delete a stateroot is ostree admin stateroot-delete. Using the wrong command in the documentation could lead to user confusion and errors.

Suggested change
sudo ostree admin stateroot-init --delete default
sudo ostree admin stateroot-delete default

Assisted-by: Claude Code
Signed-off-by: ckyrouac <[email protected]>
Copy link
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me!


# Remove the old deployment(s) by index
# The index is shown in the output (e.g., "1" for the second deployment)
ostree admin undeploy <index>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is something we need to wrap in bootc more nicely...perhaps something like bootc stateroot rm <name> or so that would also remove all deployments associated with it?

@cgwalters cgwalters enabled auto-merge (rebase) October 30, 2025 20:17
@cgwalters cgwalters merged commit 338aaab into bootc-dev:main Oct 30, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Updates to the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants