- 
                Notifications
    
You must be signed in to change notification settings  - Fork 143
 
docs: Add docs for install reset to experimental section #1717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for the new experimental bootc install reset command. The new documentation is clear and well-structured, providing a good overview, usage examples, and details on the feature. I've identified one issue in a command example for cleaning up old stateroots and have provided a correction.
| ls -la /sysroot/ostree/deploy/ | ||
| 
               | 
          ||
| # Remove the old stateroot (replace 'default' with your old stateroot name) | ||
| sudo ostree admin stateroot-init --delete default | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command provided for cleaning up an old stateroot appears to be incorrect. ostree admin stateroot-init is used for initializing a stateroot, not deleting one. The correct command to delete a stateroot is ostree admin stateroot-delete. Using the wrong command in the documentation could lead to user confusion and errors.
| sudo ostree admin stateroot-init --delete default | |
| sudo ostree admin stateroot-delete default | 
40a1cd9    to
    0265615      
    Compare
  
    Assisted-by: Claude Code Signed-off-by: ckyrouac <[email protected]>
0265615    to
    22d26bd      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me!
| 
               | 
          ||
| # Remove the old deployment(s) by index | ||
| # The index is shown in the output (e.g., "1" for the second deployment) | ||
| ostree admin undeploy <index> | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is something we need to wrap in bootc more nicely...perhaps something like bootc stateroot rm <name> or so that would also remove all deployments associated with it?
Assisted-by: Claude Code