Allow TimeZoneProvider to be configurable via the ContextBuilder #4447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes
Fixed tests (53): |
|
NOTE: the tests are not from this PR, but the |
HalidOdat
approved these changes
Oct 2, 2025
jedel1043
reviewed
Oct 7, 2025
| #[cfg(feature = "temporal")] | ||
| pub(crate) fn tz_provider(&self) -> &impl TimeZoneProvider { | ||
| &self.tz_provider | ||
| pub(crate) fn timezone_provider(&self) -> &impl TimeZoneProvider { |
There was a problem hiding this comment.
I'd expose this as &dyn TimeZoneProvider instead, which avoids the additional generic (impl)
jedel1043
reviewed
Oct 7, 2025
| } | ||
| } | ||
|
|
||
| /// The `DynamicTimeZoneProvider` is a wrapper type that allows users |
There was a problem hiding this comment.
Why not use Box<dyn TimeZoneProvider> directly instead? We don't need a wrapper in this case, since the provider is only accessible within the crate
jedel1043
requested changes
Oct 7, 2025
|
Probably blocked on boa-dev/temporal#599 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to work on #1804
It changes the following:
DynamicTimeZoneProvider.TimeZoneProvideronContextBuilder.This is related to the general API, so please feel free to let me know if you think this is the wrong approach.
Assuming we're happy with the result of this PR and its merged, I would be fine removing Temporal from the
experimentalfeature flags for the next release. We still need to figure out a good way to make reading the host system time zone accessible, but that's still an odd aspect of the specification itself.