-
-
Notifications
You must be signed in to change notification settings - Fork 456
[DRAFT] feat: console.table implementation #4122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4122 +/- ##
==========================================
+ Coverage 47.24% 53.81% +6.57%
==========================================
Files 476 485 +9
Lines 46892 48386 +1494
==========================================
+ Hits 22154 26040 +3886
+ Misses 24738 22346 -2392 ☔ View full report in Codecov by Sentry. |
Yeah this is a good start, you'll then either need a specialized formatter or an argument to the current formatter. if you were curious of other implementations, this is node.js' verison: Node's test suite for console.table: It doesn't look like the algorithm has been formally specified, the last discussion was here: |
Thank you @jasonwilliams for your feedback. I will look into the nodejs implementation. |
Hey @sumitparakh how did you get on with this, are you still working on it? |
Hi @jasonwilliams , i have some new changes in my local but due to some work pressure i couldn't continue further. I will start working on this again. Sorry for taking time |
Hi @sumitparakh @jasonwilliams , I noticed this PR has been inactive for a while. I’d love to help move this forward — would it be okay if I continue work on it in a separate PR? |
console.table
features: -This Pull Request fixes/closes #3806
It changes the following: