Skip to content

#127: add apache-airflow to mapping #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#127: add apache-airflow to mapping #180

wants to merge 1 commit into from

Conversation

brentfollin
Copy link

add apache-airflow instead of airflow to requirements.txt.

See https://pypi.org/project/airflow/

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 70.833% when pulling 45b987c on brentfollin:add-apache-airflow-to-mapping into 6ca1f42 on bndr:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 70.833% when pulling 45b987c on brentfollin:add-apache-airflow-to-mapping into 6ca1f42 on bndr:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 70.833% when pulling 45b987c on brentfollin:add-apache-airflow-to-mapping into 6ca1f42 on bndr:master.

@coveralls
Copy link

coveralls commented Nov 21, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 71.048% when pulling 45b987c on brentfollin:add-apache-airflow-to-mapping into 6ca1f42 on bndr:master.

alan-barzilay
alan-barzilay requested changes Mar 24, 2021
View reviewed changes
Copy link
Collaborator

@alan-barzilay alan-barzilay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis seems to have failed the build for some internal connectivity issues. If the mapping is reversed I can merge this PR

pipreqs/mapping
@@ -1,6 +1,7 @@
AG_fft_tools:agpy
ANSI:pexpect
Adafruit:Adafruit_Libraries
apache-airflow:airflow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you reversed it, it should be import_name:pypi_name, like so:
airflow:apache-airflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-barzilay alan-barzilay alan-barzilay requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brentfollin @coveralls @alan-barzilay