Warn when pypi queries fail #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to identify cases when a name should have a mapping but doesn't.
Currently, pipreqs silently ignores missing packages or network errors unless --debug is supplied. requirements.txt still gets built, but is likely to be wrong. This prints appropriate warnings when something goes wrong querying pypi. For nonexistent packages, it suggests a missing mapping as a possible culprit.
|
I was cleaning up some of my stale PRs and noticed this was still open with no commits to the repo for a year. Is pipreqs not maintained anymore? Has development moved elsewhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, pipreqs silently ignores pypi errors unless --debug is
supplied. In particular, when a name needs to be in the mapping file but
isn't, pipreqs will look for it on pypi, fail to find it, and skip it
without comment. requirements.txt still gets built, but is likely to be
wrong.
This PR makes it treat pypi errors as warning-worthy, and adds some
debugging lines around mapping lookups.