feat: makes revm sp1 compatible through feature controlling #84

ZhAnGeek · 2024-11-06T08:09:24Z

Description

makes revm sp1 compatible through feature controlling

Rationale

adapt revm to be compilable for risv32 and so as to prove opbnb blocks

Changes

cometbft default features set to false to disable cometbft-rpc http-client feature.
tendermint set to optional, and removed tendermint dependency when the feature does not contain bsc.
export opbnb precompile cometbft_light_block_validation and bls_signature_validation and their mods.

* feat: implement precompile contract for opBNB * fix: unused import warning in test * ci: add develop branch to the list of branches to run * chore: fmt codes * chore: fix no default feature importing * chore: cargo clippy fix * ci: disable checks on riscv32imac-unknown-none-elf * chore: setup vec with capacity * fix: cometbft_light_block_validate input conversion * chore: fix fmt * fix: add opbnb feature to ECOTONE * fix: sepc definition * chore: fix opBNB feature tags * chore(ci): bump action/deploy (#1372) * fix: light block header validation in cometbft * chore: fix fmt * fix: BLS_SIGNATURE_VALIDATION_BASE to 1000 * update greenfield-cometbft-rs version --------- Co-authored-by: rakita <[email protected]> Co-authored-by: Keefe Liu <[email protected]>

* feat(optimism): Add secp256r1 precompile for Fjord (#1436) * feat(optimism): Add secp256r1 precompile for Fjord * Fix docs * Fix nostd build * Load fjord precompiles via optimism handler register * Remove outdated fjord() precompile spec constructor * Document the secp256r1 feature * Address feedback * Handle invalid signatures * Update crates/precompile/src/secp256r1.rs * Update crates/precompile/src/secp256r1.rs * Blank return on failed signature verification * Add test case for invalid (zero) pubkey --------- Co-authored-by: rakita <[email protected]> * feat: add Haber spec to opBNB --------- Co-authored-by: Brian Bland <[email protected]> Co-authored-by: rakita <[email protected]>

# Conflicts: # .github/workflows/book.yml # .github/workflows/cachegrind.yml # Cargo.lock # crates/interpreter/src/instructions/opcode.rs # crates/precompile/Cargo.toml # crates/precompile/src/lib.rs # crates/primitives/src/specification.rs # crates/revm/src/optimism/handler_register.rs

chore: merge upstream changes into develop

* feat: add support for BSC * fix precompile contracts error * optimize `specification` setting * fix lint issues * fix CI issues * fix CI issues * fix CI issues * fix wrong precompile contracts set * fix precompile revert error * add check for bsc precompile * add `PrecompileError::Reverted` * fix evm spec for `KEPLER` * fix CI issues * add `haber` precompile set and fix errors * add EIP4844 data fee to `collect_system_reward` * update bsc feature dep * fix review comments * update `tendermint` version

# Conflicts: # Cargo.lock # crates/precompile/Cargo.toml # crates/precompile/src/lib.rs # crates/revm/src/context/evm_context.rs

chore: merge with upstream

chore: merge v37 version into develop

# Conflicts: # .github/workflows/ci.yml # Cargo.lock # crates/precompile/Cargo.toml # crates/precompile/src/lib.rs

chore: merge with upstream v11.0.0

* feat: add bohr upgrade for BSC * fix lint error * fix lint error * fix lint error

* defer bytecode load * apply review

Bumps [bitflags](https://github.com/bitflags/bitflags) from 2.5.0 to 2.6.0. - [Release notes](https://github.com/bitflags/bitflags/releases) - [Changelog](https://github.com/bitflags/bitflags/blob/main/CHANGELOG.md) - [Commits](bitflags/bitflags@2.5.0...2.6.0) --- updated-dependencies: - dependency-name: bitflags dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [serde](https://github.com/serde-rs/serde) from 1.0.203 to 1.0.204. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.203...v1.0.204) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.117 to 1.0.120. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.117...v1.0.120) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: use `kzg-rs` * fix: use `c-kzg` by default in std env * refactor: feature gate by `c-kzg` * fix: use published crate * fix: `kzg-rs` import * feat: use `cfg_if` for `kzg-rs` imports * feat: use `kzg-rs` * fix: `kzg-rs` import * chore: add `kzg-rs` feature to revm-interpreter * fix: check kzg-rs enable in revm/precompile * fix: kzg-rs include once_cell and derive_more in primitives, update feature tags * Update crates/primitives/src/lib.rs * Update crates/precompile/src/lib.rs * Update crates/primitives/Cargo.toml * Update crates/revm/Cargo.toml * Update crates/precompile/Cargo.toml * Update crates/primitives/src/lib.rs --------- Co-authored-by: rakita <[email protected]>

…1600) * chore: Refactor code, and check is precompile for create colision * remove some TODOs for eofcreate nonce

* fix(EOF): MIN_CALLEE_GAS light failure, static-mode check * clear buffer * readd min caller gas

release: prepare for v1.0.3

chore: merge upstream v14.0.3

chore: merge develop into main

ZhAnGeek · 2024-11-11T09:53:09Z

crates/precompile/src/cometbft.rs

        vec![0; (VALIDATE_RESULT_METADATA_LENGTH + consensus_state_bytes.len() as u64) as usize];
    output[0] = if validator_set_changed { 1 } else { 0 };
-    output[24..32].copy_from_slice(consensus_state_bytes.len().to_be_bytes().as_ref());
+    output[24..32].copy_from_slice((consensus_state_bytes.len() as u64).to_be_bytes().as_ref());


Compatibility for 32-bit system, risv32 running panic for this line due to mismatch len

pythonberg1997 · 2024-11-12T09:56:45Z

crates/precompile/src/lib.rs

 #![cfg_attr(not(test), warn(unused_crate_dependencies))]
 #![cfg_attr(not(feature = "std"), no_std)]
+#![allow(unused_mut)]
+#![allow(unused_crate_dependencies)]


We'd better remove this to keep deps clean

j75689 and others added 30 commits May 21, 2024 11:52

fix: cometbft contract (bnb-chain#21)

4be2578

chore: fix ci issues (bnb-chain#22)

deb253b

chore: add pr template (bnb-chain#24)

7c1d81e

resolve merge conflicts

b4c100b

Merge pull request bnb-chain#28 from bnb-chain/roshan/merge-upstream

cd1ce9b

chore: merge upstream changes into develop

Merge branch 'refs/heads/upstream' into parlia

cd1ae53

# Conflicts: # Cargo.lock # crates/precompile/Cargo.toml # crates/precompile/src/lib.rs # crates/revm/src/context/evm_context.rs

chore: resolve merge conflicts

88cc933

Merge pull request bnb-chain#34 from bnb-chain/roshan/parlia

e7e3479

chore: merge with upstream

Merge tag 'v37' into develop

63b8ab8

Merge pull request bnb-chain#38 from bnb-chain/merge_v37

5a1e473

chore: merge v37 version into develop

upgrade: add HaberFix for bsc (bnb-chain#39)

e1124e4

fix: fix the hardforks' order (bnb-chain#43)

e4bf75d

Merge branch 'refs/heads/develop' into merge-v11.0.0

c7cac63

# Conflicts: # .github/workflows/ci.yml # Cargo.lock # crates/precompile/Cargo.toml # crates/precompile/src/lib.rs

chore: resolve merge conflicts

fa5328b

Merge pull request bnb-chain#47 from pythonberg1997/merge-v11.0.0

0fceb63

chore: merge with upstream v11.0.0

feat: add bohr hardfork for bsc (bnb-chain#49)

8a18176

* feat: add bohr upgrade for BSC * fix lint error * fix lint error * fix lint error

bump: main CHANGELOG (#1592)

d30e986

chore: Rename gas_price to gas_limit for precompile args (#1593)

4ef7272

chore(revm): defer bytecode load (#1588)

6f7912b

* defer bytecode load * apply review

chore: Refactor code, and check if precompile for create collision (#…

aae840e

…1600) * chore: Refactor code, and check is precompile for create colision * remove some TODOs for eofcreate nonce

fix(EOF): MIN_CALLEE_GAS light failure, static-mode check (#1599)

48409bc

* fix(EOF): MIN_CALLEE_GAS light failure, static-mode check * clear buffer * readd min caller gas

refactor: load_account -> warm_preloaded_addresses (#1584)

19cb8a8

j75689 and others added 5 commits October 9, 2024 11:06

Merge pull request bnb-chain#77 from bnb-chain/develop

2ed706a

release: prepare for v1.0.3

Merge tag 'v45' into merge-v1.0.8

71b3bb8

chore: fix ci issues

a0b3a25

Merge pull request bnb-chain#78 from bnb-chain/merge-v1.0.8

01d2e6c

chore: merge upstream v14.0.3

Merge pull request bnb-chain#82 from bnb-chain/develop

0978bcb

chore: merge develop into main

ZhAnGeek force-pushed the feat--makes-revm-sp1-compatible-through-feature-controlling branch 7 times, most recently from 3de530c to 39dde2a Compare November 6, 2024 09:37

feat: makes revm sp1 compatible through feature controlling

52c7199

ZhAnGeek force-pushed the feat--makes-revm-sp1-compatible-through-feature-controlling branch from 39dde2a to 52c7199 Compare November 6, 2024 09:52

pythonberg1997 and others added 2 commits November 8, 2024 09:20

test: update feature control

96c8eee

fix: precompile issue for risv32 bytes len array

4197e85

ZhAnGeek force-pushed the feat--makes-revm-sp1-compatible-through-feature-controlling branch 2 times, most recently from eb6eb74 to 88c3a49 Compare November 11, 2024 07:54

feat: optimize dep

b8d59fa

ZhAnGeek force-pushed the feat--makes-revm-sp1-compatible-through-feature-controlling branch from 88c3a49 to b8d59fa Compare November 11, 2024 08:08

ZhAnGeek commented Nov 11, 2024

View reviewed changes

pythonberg1997 reviewed Nov 12, 2024

View reviewed changes

ZhAnGeek force-pushed the feat--makes-revm-sp1-compatible-through-feature-controlling branch 4 times, most recently from ee7ce1b to 14d8659 Compare November 12, 2024 11:37

ZhAnGeek requested a review from pythonberg1997 November 12, 2024 11:45

fix: removed unneccesary global mark

3dff0d3

ZhAnGeek force-pushed the feat--makes-revm-sp1-compatible-through-feature-controlling branch from 14d8659 to 3dff0d3 Compare November 12, 2024 11:46

sunny2022da force-pushed the main branch from d66170e to 0ca6564 Compare September 3, 2025 02:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: makes revm sp1 compatible through feature controlling #84

feat: makes revm sp1 compatible through feature controlling #84

Uh oh!

ZhAnGeek commented Nov 6, 2024

Uh oh!

ZhAnGeek Nov 11, 2024

Uh oh!

pythonberg1997 Nov 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

feat: makes revm sp1 compatible through feature controlling #84

Are you sure you want to change the base?

feat: makes revm sp1 compatible through feature controlling #84

Uh oh!

Conversation

ZhAnGeek commented Nov 6, 2024

Description

Rationale

Changes

Uh oh!

ZhAnGeek Nov 11, 2024

Choose a reason for hiding this comment

Uh oh!

pythonberg1997 Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants