-
Notifications
You must be signed in to change notification settings - Fork 631
display copy button for tx hashes in relevant components #3031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iamenochlee
wants to merge
9
commits into
blockscout:main
Choose a base branch
from
iamenochlee:display-copy-button-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@iamenochlee could you please rebase to the current main branch so we can run tests and code quality workflows? |
36aeb06
to
034fb3d
Compare
@isstuev you can check it out now |
all good for a merge |
i see the failing tests, currently checking |
@isstuev sorted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Related Issue(s)
This pull request enables the copy button for transaction hash in transaction lists by default while ensuring it is only displayed in relevant pages/tabs mostly user specific ones such as:
https://eth.blockscout.com/address/0x5AbFEc25f74Cd88437631a7731906932776356f9?tab=txs
https://eth.blockscout.com/address/0x5AbFEc25f74Cd88437631a7731906932776356f9?tab=internal_txns
Previously, users could not easily copy transaction hashes from list views, requiring them to navigate to individual transaction pages.
*Resolves #2592 *
Proposed Changes
TxEntity.tsx
and other similarTxEntityXXX.tsx
component to display copy buttons by default for transaction hashes, improving user experience when interacting with transaction dataCopy
component logic to setnoCopy={ props.noCopy}
, making copy buttons for tx hash visible unless explicitly disabledui/address/[0x]/txs
)ui/address/[0x]/internalTxs
)ui/address/[0x]/tokenTransfers
)noCopy
prop) on system-wide pages where copy functionality may be less relevant or could clutter the interfacenoCopy={false}
props from user-focused components where copy buttons should now display by defaultThis enhancement provides a more intuitive and user-friendly approach to transaction hash copying, making the functionality available where users expect it while keeping system-wide interfaces clean and focused.
No changes were made to ENV variables.
Breaking or Incompatible Changes
No breaking changes. This is a purely additive enhancement that improves UX. The copy button can still be hidden by explicitly setting
noCopy={true}
if needed in specific implementations.Additional Information
This enhancement improves user workflow by allowing direct copying of transaction hashes from list views without requiring navigation to individual transaction pages. The change maintains backward compatibility while providing better default behavior.
Checklist for PR author