-
Notifications
You must be signed in to change notification settings - Fork 180
feat(stats): network utilization chart #1341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
28ca867 to
e25a6dd
Compare
e25a6dd to
03f134b
Compare
|
@coderabbitai review pls |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: Length of output: 36788 @bragov4ik I've completed my review of PR #1341 "feat(stats): network utilization chart". Here's my assessment: OverallThis is a well-implemented feature that adds two valuable charts:
The code is well-structured and follows the established patterns in the codebase. Strengths
Minor Observations
The PR looks ready to merge. Great work on implementing these useful metrics! |
network utilization is computed as gas used divided by gas limit.
average/averagealso works becausetotal=average*countand count just cancels out.also added another initial update status state: queued for initial update
it should exempt such charts from not being shown in charts page (like those whose requirements are not met, e.g. user ops charts when user ops indexer is disabled) (closes #1342)
its scope is only one commit: 1074351