-
Notifications
You must be signed in to change notification settings - Fork 1
Optimize rewards and enable actual autocompounding #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
moliholy
wants to merge
54
commits into
main
Choose a base branch
from
feat/optimized-rewrads
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
980aa74
to
a9d2736
Compare
75998e2
to
3fbfeb1
Compare
6fa04cc
to
b205dee
Compare
9428300
to
9fde453
Compare
* Added test for invalid origins * refactor * Addressed comments
b44f16b
to
f9df0ac
Compare
f9df0ac
to
5d6fc17
Compare
* Refactor autocompund test * Added Autocompounding test * Fix setting autocompound to false * Added invalid origin tests * Add more tests --------- Co-authored-by: José Molina <[email protected]>
* choir: add comments related to reward mechanism * Improve documentation --------- Co-authored-by: José Molina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the current per-session reward system into a counter-checkpoint system, bringing the following features: